Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO_ISSUE: Fix hello world documentation POST in dmn-drools-springboot-metrics #2007

Open
wants to merge 1 commit into
base: stable
Choose a base branch
from

Conversation

kgeis
Copy link

@kgeis kgeis commented Sep 3, 2024

Running the curl command as documented returns ["world"] and it should return ["hello", "world"].

Copy link
Contributor

@domhanak domhanak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jomarko mind taking a look?

@domhanak domhanak changed the title KOGITO-fix hello world documentation POST example NO_ISSUE: Fix hello world documentation POST in dm-drools-springboot-metrics Jan 15, 2025
@domhanak domhanak changed the title NO_ISSUE: Fix hello world documentation POST in dm-drools-springboot-metrics NO_ISSUE: Fix hello world documentation POST in dmn-drools-springboot-metrics Jan 15, 2025
Copy link

@jomarko jomarko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am fine with this change. However there is discussion about the examples, also about the stable branch and I am not sure about its future.

https://lists.apache.org/thread/qc9vhod96mdoppo5ssj4f0pkqhzt4ghd

Could we please address this issue also on main branch?
https://github.com/apache/incubator-kie-kogito-examples/tree/main/kogito-springboot-examples/dmn-drools-springboot-metrics

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants