-
Notifications
You must be signed in to change notification settings - Fork 69
fix(ci): upgrade ubuntu version of GitHub action runner #694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #694 +/- ##
===========================================
+ Coverage 59.94% 95.11% +35.16%
===========================================
Files 65 8 -57
Lines 9213 737 -8476
Branches 975 0 -975
===========================================
- Hits 5523 701 -4822
+ Misses 3690 36 -3654 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
.github/workflows/spark.yaml
Outdated
@@ -39,7 +39,7 @@ concurrency: | |||
|
|||
jobs: | |||
test: | |||
runs-on: ubuntu-20.04 | |||
runs-on: ubuntu-22.04 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless there's a specific reason not to, I tend to go with the ubuntu-latest label.
Both Spark 3.2 and 3.3 are not maintained anymore. What do you think about dropping them instead of trying to fix the failing CI on a newer Ubuntu containers? |
Thanks for your suggestion @SemyonSinchenko . I agree with you. |
It seems that ci run failed because of cannot access class sun.nio.ch.DirectBuffer. And it seems happen in Java17, but our ci test run on Java11: incubator-graphar/.github/workflows/spark.yaml Lines 94 to 97 in 37b046e
Maybe we should set the VM option |
Reason for this PR
close #693
What changes are included in this PR?
edit spark ci file, and upgrade ubuntu version of GitHub action runner
Are these changes tested?
Are there any user-facing changes?