Skip to content

fix(ci): upgrade ubuntu version of GitHub action runner #694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

Thespica
Copy link
Contributor

Reason for this PR

close #693

What changes are included in this PR?

edit spark ci file, and upgrade ubuntu version of GitHub action runner

Are these changes tested?

Are there any user-facing changes?

@codecov-commenter
Copy link

codecov-commenter commented May 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.11%. Comparing base (ba30326) to head (2f56988).
Report is 8 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #694       +/-   ##
===========================================
+ Coverage   59.94%   95.11%   +35.16%     
===========================================
  Files          65        8       -57     
  Lines        9213      737     -8476     
  Branches      975        0      -975     
===========================================
- Hits         5523      701     -4822     
+ Misses       3690       36     -3654     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@@ -39,7 +39,7 @@ concurrency:

jobs:
test:
runs-on: ubuntu-20.04
runs-on: ubuntu-22.04
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless there's a specific reason not to, I tend to go with the ubuntu-latest label.

@SemyonSinchenko
Copy link
Member

Both Spark 3.2 and 3.3 are not maintained anymore. What do you think about dropping them instead of trying to fix the failing CI on a newer Ubuntu containers?

@Thespica
Copy link
Contributor Author

Both Spark 3.2 and 3.3 are not maintained anymore. What do you think about dropping them instead of trying to fix the failing CI on a newer Ubuntu containers?

Thanks for your suggestion @SemyonSinchenko . I agree with you.

@Thespica
Copy link
Contributor Author

Thespica commented May 30, 2025

It seems that ci run failed because of cannot access class sun.nio.ch.DirectBuffer.

And it seems happen in Java17, but our ci test run on Java11:

- name: Run test
working-directory: maven-projects/spark
run: |
export JAVA_HOME=${JAVA_HOME_11_X64}

Maybe we should set the VM option --add-exports java.base/sun.nio.ch=ALL-UNNAMED to allow that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix(ci): upgrade ubuntu version of GitHub action runner
4 participants