Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VL] Support loading dependency libs for Oracle linux #8391

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

xinghuayu007
Copy link
Contributor

What changes were proposed in this pull request?

As Oracle systems are widely used in many companies, it is better to support compiling Gluten on this systems.
And Oracle systems are almost similar to Centos systems. I put them into one kind of OS system.

How was this patch tested?

The UTs have been ran on a Oracle 7/8 system.

(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)

@github-actions github-actions bot added the VELOX label Jan 2, 2025
Copy link

github-actions bot commented Jan 2, 2025

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

@PHILO-HE PHILO-HE changed the title [GLUTEN] Support compiling on Oracle systems [VL] Support loading dependency libs for Oracle operating systems Jan 3, 2025
@PHILO-HE PHILO-HE changed the title [VL] Support loading dependency libs for Oracle operating systems [VL] Support loading dependency libs for Oracle linux Jan 3, 2025
Copy link
Contributor

@PHILO-HE PHILO-HE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your patch!

@PHILO-HE PHILO-HE merged commit 8decd00 into apache:main Jan 3, 2025
46 checks passed
@FelixYBW
Copy link
Contributor

FelixYBW commented Jan 3, 2025

@PHILO-HE with static build, we actually support all type of OSes, right?

@PHILO-HE
Copy link
Contributor

PHILO-HE commented Jan 6, 2025

@PHILO-HE with static build, we actually support all type of OSes, right?

@FelixYBW, yes, mainstream unix-like OSes are supported by using static build. This pr is focusing on the fix for dynamic build on oracle linux.

@FelixYBW
Copy link
Contributor

FelixYBW commented Jan 6, 2025

@FelixYBW, yes, mainstream unix-like OSes are supported by using static build. This pr is focusing on the fix for dynamic build on oracle linux.

Let's add it to document. I will submit a PR.

@FelixYBW
Copy link
Contributor

FelixYBW commented Jan 6, 2025

@xinghuayu007 will you consider to use static link (vcpkg=on) way? All of gluten CI are using static link now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants