[VL] Support casting timestamp type to varchar type #8338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/apache/incubator-gluten/issues Then could you also rename commit message and pull request title in the following format? See also: |
PHILO-HE
force-pushed
the
fix-timestamp-involved-cast
branch
from
2a0e02f to
d15c889
Compare
zml1206
reviewed
Dec 25, 2024
| @@ -301,7 +301,7 @@ bool SubstraitToVeloxPlanValidator::validateCast( | |||
| return false; | |||
| case TypeKind::TIMESTAMP: | |||
| // Only support cast timestamp to date | |||
There was a problem hiding this comment.
Comment need change.
I remember that cast timestamp to varchar will get incorrect results. Can the velox changes here fix it? @PHILO-HE
There was a problem hiding this comment.
@zml1206, thanks for your comment! Yes, Spark UTs have uncovered some wrong result issue. I am still trying to fix all issues.
PHILO-HE
force-pushed
the
fix-timestamp-involved-cast
branch
from
d15c889 to
99be2a0
Compare
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
To align with Spark, we need consider session timezone in this cast operation. See facebookincubator/velox#11958
How was this patch tested?
Existing imported Spark tests.