Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GLUTEN-8340][VL] Enable from_json function #8320

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[GLUTEN-8340][VL] Enable from_json function #8320

wants to merge 2 commits into from

Conversation

zhli1142015
Copy link
Contributor

@zhli1142015 zhli1142015 commented Dec 24, 2024 •
edited
Loading

What changes were proposed in this pull request?

Fixes: #8340

How was this patch tested?

UT.

@github-actions github-actions bot added CORE works for Gluten Core BUILD VELOX labels Dec 24, 2024
@github-actions GitHub Actions
Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

@github-actions GitHub Actions
Copy link

Run Gluten ClickHouse CI on ARM

@zhli1142015 zhli1142015 mentioned this pull request Dec 24, 2024
Open
@github-actions GitHub Actions
Copy link

Run Gluten ClickHouse CI on ARM

@github-actions GitHub Actions
Copy link

Run Gluten ClickHouse CI on ARM

@zhli1142015
Copy link
Contributor Author

cc @PHILO-HE , thanks.

PHILO-HE
PHILO-HE reviewed Dec 25, 2024
View reviewed changes
Copy link
Contributor

@PHILO-HE PHILO-HE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Some minor comments.

shims/common/src/main/scala/org/apache/gluten/GlutenConfig.scala Outdated Show resolved Hide resolved
backends-velox/src/test/scala/org/apache/gluten/execution/VeloxJsonFunctionsSuite.scala Outdated Show resolved Hide resolved
@zhouyuan
Copy link
Contributor

@zhli1142015 thanks a lot for the patch, would you please help to create one issue to track this? I assume there will be some follow up patches required

@github-actions GitHub Actions
Copy link

Run Gluten Clickhouse CI on x86

@zhli1142015 zhli1142015 changed the title [VL] Enable from_json function [GLUTEN-8340][VL] Enable from_json function Dec 25, 2024
@github-actions GitHub Actions
Copy link

#8340

@zhli1142015
Copy link
Contributor Author

@zhli1142015 thanks a lot for the patch, would you please help to create one issue to track this? I assume there will be some follow up patches required

Yes, #8340. This patch targets phase 1 only.

@zhli1142015 zhli1142015 requested a review from PHILO-HE December 25, 2024 06:10
@zhouyuan
Copy link
Contributor

zhouyuan commented Jan 2, 2025

pending: facebookincubator/velox#11709

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayushi-agarwal ayushi-agarwal ayushi-agarwal left review comments

@zhouyuan zhouyuan Awaiting requested review from zhouyuan

@rui-mo rui-mo Awaiting requested review from rui-mo

@PHILO-HE PHILO-HE Awaiting requested review from PHILO-HE

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
BUILD CORE works for Gluten Core VELOX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[VL] Support from_json function
4 participants
@zhli1142015 @zhouyuan @PHILO-HE @ayushi-agarwal