Skip to content

Commit

Permalink
Try to set max_threads to 1, but GlutenClickHouseTPCHColumnarShuffleP…
Browse files Browse the repository at this point in the history
…arquetAQESuite::q1 and q2 will fail
  • Loading branch information
baibaichen committed Dec 31, 2024
1 parent 29a3a6d commit 2bef7f7
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions cpp-ch/local-engine/Common/CHUtil.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@ extern const ServerSettingsDouble primary_index_cache_size_ratio;
namespace Setting
{
extern const SettingsBool query_plan_enable_optimizations;
extern const SettingsMaxThreads max_threads;
extern const SettingsUInt64 prefer_external_sort_block_bytes;
extern const SettingsUInt64 max_bytes_before_external_sort;
extern const SettingsDouble max_bytes_ratio_before_external_sort;
Expand Down Expand Up @@ -636,6 +637,9 @@ void BackendInitializerUtil::initSettings(const SparkConfigs::ConfigMap & spark_
settings.set("input_format_parquet_enable_row_group_prefetch", false);
settings.set("output_format_parquet_use_custom_encoder", false);

// TODO: we need set Setting::max_threads to 1 by default, but now we can't get correct metrics for the some query if we set it to 1.
//settings[Setting::max_threads] = 1;

// TODO: set default to true when metrics could be collected while ch query plan optimization is enabled.
settings[Setting::query_plan_enable_optimizations] = false;

Expand Down

0 comments on commit 2bef7f7

Please sign in to comment.