Core: Fix move/update/makeRequire/makeOptional fail after rename schema (#10830) #12202
+71
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manuzhang
reviewed
Feb 10, 2025
| @@ -240,7 +240,10 @@ public UpdateSchema makeColumnOptional(String name) { | |||
| } | |||
|
|
|||
| private void internalUpdateColumnRequirement(String name, boolean isOptional) { | |||
| Types.NestedField field = findField(name); | |||
| Types.NestedField field = findFieldFromUpdate(name); | |||
| if (field == null) { | |||
There was a problem hiding this comment.
this would be better handled in findFieldFromUpdate.
There was a problem hiding this comment.
Thanks for code review! I hope findFieldFromUpdate will find field from updates only, but add a new method do findFieldFromUpdate first and then findField if findFieldFromUpdate return null will be better, because there are duplicated codes, is that means?
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some SchemaUpdate API will fail after renameColumn including updateColumn, updateColumnDoc, requireColumn, makeColumnOptional, moveFirst, moveBefore and moveAfter. We don't fix every api after rename because some can be avoid by appropriate API restructuring, for example, renameColumn after renameColumn can be simplified to one rename, deleteColumn after renameColumn can be simplified to delete only because the field no need any more