Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auth Manager API part 6: API enablement #12197

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

adutra
Copy link
Contributor

@adutra adutra commented Feb 7, 2025

6th and last PR for the Auth Manager API. Previous ones:

Once this PR is merged, the AuthManager API becomes effective.

Summary of changes:

  • Minor changes to OAuth2Manager, mostly to properly handle empty auth sessions, as decided in Auth Manager API part 4: RESTClient, HTTPClient #11992;
  • Enablement of SigV4 AuthManager and removal of HttpInterceptor code in HTTPClient and related tests;
  • Enablement of AuthManager API in RESTSessionCatalog;
  • Enablement of AuthManager API in credential refreshing code: VendedCredentialsProvider and OAuth2RefreshCredentialsHandler
    • OAuth2RefreshCredentialsHandler now caches its HTTPClient and AuthSession, instead of creating a new client and session for every refresh – pretty much like VendedCredentialsProvider already does.

@adutra adutra changed the title Auth manager 6 final2 Auth Manager API part 6: API enablement Feb 7, 2025
Copy link
Member

@jbonofre jbonofre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I just wonder if S3FileIO is not impacted (around the credentials).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants