API: Null check for auto-unboxed field id in builder #12165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amogh-jahagirdar
approved these changes
Feb 3, 2025
ebyhr
approved these changes
Feb 4, 2025
Fokko
approved these changes
Feb 4, 2025
nastra
reviewed
Feb 4, 2025
nastra
reviewed
Feb 4, 2025
nastra
reviewed
Feb 4, 2025
nastra
approved these changes
Feb 4, 2025
Co-authored-by: Eduard Tudenhoefner <[email protected]>
Co-authored-by: Eduard Tudenhoefner <[email protected]>
Co-authored-by: Eduard Tudenhoefner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The NestedField builder relies on the NestedField constructor to validate values, but the builder uses
Integerfor the id value whereas the constructor usesint.This results in a confusing auto-unboxing related NPE if a field id is not provided to the builder. This PR adds a check prior to the auto-unboxing to provide a reasonable message that the field id is required.