Test Hive: Fix TestHiveMetastore #12140
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SystemClassLoader swap to getClassLoader add try-resources for connection in derby db
| @@ -273,13 +274,13 @@ private void initConf(HiveConf conf, int port) { | |||
| } | |||
|
|
|||
| private static void setupMetastoreDB(String dbURL) throws SQLException, IOException { | |||
| Connection connection = DriverManager.getConnection(dbURL); | |||
| ScriptRunner scriptRunner = new ScriptRunner(connection, true, true); | |||
| try (Connection connection = DriverManager.getConnection(dbURL)) { | |||
There was a problem hiding this comment.
I think we should still fail if this doesn't work, so Try with resources is good but we should rethrow after closing
There was a problem hiding this comment.
NVM I didn't read the standard enough. Looks like we should still rethrow
RussellSpitzer
approved these changes
Feb 1, 2025
|
@2MD, please run |
nastra
reviewed
Feb 3, 2025
| InputStream inputStream = classLoader.getResourceAsStream("hive-schema-3.1.0.derby.sql"); | ||
| try (Reader reader = new InputStreamReader(inputStream)) { | ||
| scriptRunner.runScript(reader); | ||
| InputStream inputStream = TestHiveMetastore.class.getClassLoader().getResourceAsStream("hive-schema-3.1.0.derby.sql"); |
There was a problem hiding this comment.
please wrap this also in a try-with-resources block
nastra
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #12131
SystemClassLoader swap to getClassLoader
add try-resources for connection in derby db