Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python: Add Python as a dependency #906

Closed
wants to merge 1 commit into from
Closed

Python: Add Python as a dependency #906

wants to merge 1 commit into from

Conversation

Fokko
Copy link
Contributor

@Fokko Fokko commented Jan 22, 2025 •
edited
Loading

Closes #896

@Fokko Fokko mentioned this pull request Jan 22, 2025
Closed
trim21
trim21 reviewed Jan 22, 2025
View reviewed changes
bindings/python/pyproject.toml
]

[tool.poetry.dependencies]
python = "^3.9, !=3.9.7"
Copy link
Contributor

@trim21 trim21 Jan 22, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are not using poetry as package manager in this project but actually maturin so you should not add this.

If you want to disallow 3.9.7 please add it to project.requires-python

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I'm just reading up on this. I think this is incorrect indeed. Thanks for pointing out

@Fokko Fokko closed this Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trim21 trim21 trim21 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

please add requires-python to pyproject.toml
2 participants
@Fokko @trim21