Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: spark version in integration_tests #894

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

feniljain
Copy link
Contributor

Issue

  • Spark 3.5.3 seems to have disappeared from here, there's 3.5.4 instead, so upgrading to that

Question

  • Is there any way to keep auto-updating this? Would we have to do manual version bumps everytime?

Copy link
Contributor

@kevinjqliu kevinjqliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, CI passes

For context, https://dlcdn.apache.org/spark hosts the latest version and removes the older versions. In PyIceberg we had to switch back to use archive.apache.org which hosts all versions

apache/iceberg-python#1523

@feniljain
Copy link
Contributor Author

feniljain commented Jan 16, 2025

Ohh, we recently moved away from archive here

Tho comment posted by you seems more recent and by original author (@Fokko) of above PR itself, should we change it back to archive in that case?

@kevinjqliu
Copy link
Contributor

PyIceberg is currently blocked on using 3.5.4 so we have to use archive.apache.org for the older version.

If we use dlcdn.apache.org, we would run into this issue on every new release. But it seems like the reason we moved away from archive.apache.org is because its unstable.

iceberg-rust is able to use 3.5.4 so I'm happy to merge this change.

Copy link
Contributor

@liurenjie1024 liurenjie1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @feniljain for this fix.

@liurenjie1024
Copy link
Contributor

PyIceberg is currently blocked on using 3.5.4 so we have to use archive.apache.org for the older version.

If we use dlcdn.apache.org, we would run into this issue on every new release. But it seems like the reason we moved away from archive.apache.org is because its unstable.

iceberg-rust is able to use 3.5.4 so I'm happy to merge this change.

Or should we consider using spark's container image directly?

@liurenjie1024 liurenjie1024 merged commit 425efc8 into apache:main Jan 17, 2025
17 checks passed
@kevinjqliu
Copy link
Contributor

@liurenjie1024 yea i was thinking of that too, i opened apache/iceberg-python#1527 on the python side to track this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants