-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support metadata table "History" #841
Open
rshkv
wants to merge
1
commit into
apache:main
Choose a base branch
from
rshkv:wr/metadata-history
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rshkv
commented
Dec 24, 2024
crates/iceberg/src/metadata_scan.rs
Outdated
Comment on lines
217
to
232
impl<'a> Iterator for Ancestors<'a> { | ||
type Item = &'a SnapshotRef; | ||
|
||
fn next(&mut self) -> Option<Self::Item> { | ||
if let Some(snapshot) = self.current_snapshot { | ||
self.current_snapshot = match snapshot.parent_snapshot_id() { | ||
Some(parent_snapshot_id) => self.table_metadata.snapshot_by_id(parent_snapshot_id), | ||
None => None, | ||
}; | ||
Some(snapshot) | ||
} else { | ||
None | ||
} | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PyIceberg's ancestors_of
is here
rshkv
changed the title
feat: support metadata table "history"
feat: Support metadata table "history"
Dec 25, 2024
rshkv
changed the title
feat: Support metadata table "history"
feat: Support metadata table "History"
Dec 25, 2024
#822 has been merged, let's move on! |
rshkv
force-pushed
the
wr/metadata-history
branch
from
December 30, 2024 16:27
fc5c976
to
ddb6b14
Compare
Thank you for letting me know. Rebased on |
rshkv
force-pushed
the
wr/metadata-history
branch
from
December 30, 2024 16:33
ddb6b14
to
64f1448
Compare
rshkv
force-pushed
the
wr/metadata-history
branch
from
January 2, 2025 13:10
8c803d2
to
3875931
Compare
Let's get #863 merge first. |
rshkv
force-pushed
the
wr/metadata-history
branch
from
January 8, 2025 11:54
3875931
to
93a31ed
Compare
rshkv
force-pushed
the
wr/metadata-history
branch
from
January 8, 2025 12:55
93a31ed
to
6795fce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for the History metadata table.
The history table is the snapshot log with ancestry information.
Reference implementations: