Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support metadata table "History" #841

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rshkv
Copy link
Contributor

@rshkv rshkv commented Dec 24, 2024

Add support for the History metadata table.

The history table is the snapshot log with ancestry information.

Reference implementations:

Comment on lines 217 to 232
impl<'a> Iterator for Ancestors<'a> {
type Item = &'a SnapshotRef;

fn next(&mut self) -> Option<Self::Item> {
if let Some(snapshot) = self.current_snapshot {
self.current_snapshot = match snapshot.parent_snapshot_id() {
Some(parent_snapshot_id) => self.table_metadata.snapshot_by_id(parent_snapshot_id),
None => None,
};
Some(snapshot)
} else {
None
}
}
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PyIceberg's ancestors_of is here

@rshkv rshkv changed the title feat: support metadata table "history" feat: Support metadata table "history" Dec 25, 2024
@rshkv rshkv changed the title feat: Support metadata table "history" feat: Support metadata table "History" Dec 25, 2024
@Xuanwo
Copy link
Member

Xuanwo commented Dec 30, 2024

#822 has been merged, let's move on!

@rshkv rshkv force-pushed the wr/metadata-history branch from fc5c976 to ddb6b14 Compare December 30, 2024 16:27
@rshkv rshkv marked this pull request as ready for review December 30, 2024 16:27
@rshkv
Copy link
Contributor Author

rshkv commented Dec 30, 2024

Thank you for letting me know. Rebased on main.

@Xuanwo
Copy link
Member

Xuanwo commented Jan 2, 2025

Let's get #863 merge first.

@rshkv rshkv force-pushed the wr/metadata-history branch from 93a31ed to 6795fce Compare January 8, 2025 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants