-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(puffin): Add Puffin crate and CompressionCodec #745
Conversation
8f1ae48
to
3eb4fc5
Compare
3eb4fc5
to
336df2b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes sense to me :) Thanks for working on this @fqaiser94 🙌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @fqaiser94 for working on this, and also thank you @Fokko for the review. Looks like a good start point for me. Let's move!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @fqaiser94 for this pr, just left a comment, others LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really need to put this outside of iceberg crate? I'm thinking how will we deal with PuffinReader/PuffindWriter
, which will depend on FileIO?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm thinking how will we deal with PuffinReader/PuffindWriter, which will depend on FileIO?
I don't understand why this would cause issues since FileIO
is a publicly exposed interface? 🤔
Do we really need to put this outside of iceberg crate?
That said, I think you're right.
I don't see any compelling reasons to separate this functionality into a separate crate outside of the iceberg crate.
I didn't consider this option; I just forgot 😅
Here's a quick follow-up PR to move this functionality inside of the existing iceberg crate: #789
Part of #744
Summary
CompressionCodec
(see iceberg/puffin-spec/compression-codecs for more information)Context
Out of Scope