fix: snapshot was producing empty summary #1767
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
The first line in the method
SnapshotProducer::write_added_manifest(let added_data_files = std::mem::take(&mut self.added_data_files);) sets theself.added_data_filesto an empty vec.SnapshotProducer::write_added_manifestis called via the call chainSnapshotProducer::commit->SnapshotProducer::manifest_file->SnapshotProducer::write_added_manifest). Hence, ifSnapshotProducer::summaryis called after callingSnapshotProducer::manifest_file, the summary produced was empty due to emptyself.added_data_files.This PR rearranges the code in
SnapshotProducer::committo make sure the produced summary is not empty.Are these changes tested?
No new tests have been added for this as there were no previous tests.