&BlobMetadata and update comment

apache · Jan 23, 2025 · 4d64762 · 4d64762
1 parent 9c7b8cf
commit 4d64762
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 9 deletions.
diff --git a/crates/iceberg/src/puffin/blob.rs b/crates/iceberg/src/puffin/blob.rs
@@ -31,7 +31,7 @@ pub(crate) struct Blob {
     pub(crate) snapshot_id: i64,
     /// Sequence number of the Iceberg table's snapshot the blob was computed from
     pub(crate) sequence_number: i64,
-    /// The actual blob data
+    /// The uncompressed blob data
     pub(crate) data: Vec<u8>,
     /// Arbitrary meta-information about the blob
     pub(crate) properties: HashMap<String, String>,

diff --git a/crates/iceberg/src/puffin/reader.rs b/crates/iceberg/src/puffin/reader.rs
@@ -46,20 +46,20 @@ impl PuffinReader {
     }
 
     /// Returns blob
-    pub(crate) async fn blob(&self, blob_metadata: BlobMetadata) -> Result<Blob> {
+    pub(crate) async fn blob(&self, blob_metadata: &BlobMetadata) -> Result<Blob> {
         let file_read = self.input_file.reader().await?;
         let start = blob_metadata.offset;
         let end = start + blob_metadata.length;
         let bytes = file_read.read(start..end).await?.to_vec();
         let data = blob_metadata.compression_codec.decompress(bytes)?;
 
         Ok(Blob {
-            r#type: blob_metadata.r#type,
-            fields: blob_metadata.fields,
+            r#type: blob_metadata.r#type.clone(),
+            fields: blob_metadata.fields.clone(),
             snapshot_id: blob_metadata.snapshot_id,
             sequence_number: blob_metadata.sequence_number,
             data,
-            properties: blob_metadata.properties,
+            properties: blob_metadata.properties.clone(),
         })
     }
 }
@@ -84,15 +84,15 @@ mod tests {
 
         assert_eq!(
             puffin_reader
-                .blob(file_metadata.blobs.first().unwrap().clone())
+                .blob(file_metadata.blobs.first().unwrap())
                 .await
                 .unwrap(),
             blob_0()
         );
 
         assert_eq!(
             puffin_reader
-                .blob(file_metadata.blobs.get(1).unwrap().clone())
+                .blob(file_metadata.blobs.get(1).unwrap())
                 .await
                 .unwrap(),
             blob_1(),
@@ -109,15 +109,15 @@ mod tests {
 
         assert_eq!(
             puffin_reader
-                .blob(file_metadata.blobs.first().unwrap().clone())
+                .blob(file_metadata.blobs.first().unwrap())
                 .await
                 .unwrap(),
             blob_0()
         );
 
         assert_eq!(
             puffin_reader
-                .blob(file_metadata.blobs.get(1).unwrap().clone())
+                .blob(file_metadata.blobs.get(1).unwrap())
                 .await
                 .unwrap(),
             blob_1(),