Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update all namespace properties in update_namespace_properties #873

Merged
merged 3 commits into from
Jul 4, 2024
Merged

fix: update all namespace properties in update_namespace_properties #873

merged 3 commits into from
Jul 4, 2024

Conversation

ranli
Copy link
Contributor

@ranli ranli commented Jun 30, 2024

Fixes 3rd bug listed at #864, where update_namespace_properties function only updates the first property and drops the rest

kevinjqliu
kevinjqliu reviewed Jun 30, 2024
View reviewed changes
Copy link
Contributor

@kevinjqliu kevinjqliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! I have a few minor comments. Please feel free to tag me for re-review :)

pyiceberg/catalog/sql.py Outdated Show resolved Hide resolved
tests/catalog/test_sql.py Outdated Show resolved Hide resolved
@kevinjqliu kevinjqliu mentioned this pull request Jun 30, 2024
Closed
4 tasks
@ranli
Copy link
Contributor Author

ranli commented Jun 30, 2024

@kevinjqliu updated code based on your comments.

kevinjqliu
kevinjqliu reviewed Jun 30, 2024
View reviewed changes
Copy link
Contributor

@kevinjqliu kevinjqliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ranli added a comment on readability of the test.

kevinjqliu
kevinjqliu approved these changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@kevinjqliu kevinjqliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! LGTM

@HonahX / @Fokko PTAL

HonahX
HonahX approved these changes Jul 4, 2024
View reviewed changes
Copy link
Contributor

@HonahX HonahX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ranli Thanks for the contribution! LGTM! Thanks @kevinjqliu for reviewing

@HonahX HonahX merged commit 473d28d into apache:main Jul 4, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HonahX HonahX HonahX approved these changes

@kevinjqliu kevinjqliu kevinjqliu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ranli @kevinjqliu @HonahX