Refactor GlueCatalog's _commit_table #653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #498, the
createTableTransactionAPI requires the_commit_tableto handle both table update and table creation. This PR refactors Glue's_commit_tableto re-use codes such as requirements validation, metadata update, and new metadata write between the two workflows.This refactoring also solves an extreme case where the table gets dropped after
_commit_tableload the current table and before_commit_tableupdate the table. In the previous implementation, the code will accidently slip to the table creation workflow and incorrectly create the table.Try to see if similar implementation pattern can be applied to Hive and Sql in #611