Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes, #523 followup #563

Merged
merged 4 commits into from
Mar 31, 2024
Merged

Conversation

kevinjqliu
Copy link
Contributor

Follow up to #523

Remove print in test (left it in accidentally, saw it was removed in #559)
Call .as_arrow() once
Uncomment test for sqlite

@HonahX
Copy link
Contributor

HonahX commented Mar 31, 2024

@kevinjqliu Thanks for fixing this. Do you mind cleaning up the other 2 "prints" in test_reads.py and test_writes.py too? (#562 )

@kevinjqliu
Copy link
Contributor Author

oops looks like you already had a PR. I just removed all the prints

Copy link
Contributor

@HonahX HonahX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kevinjqliu ! I will merge this when tests pass and close the other one :).

@HonahX HonahX merged commit 7e3e508 into apache:main Mar 31, 2024
7 checks passed
@HonahX HonahX mentioned this pull request Mar 31, 2024
@HonahX
Copy link
Contributor

HonahX commented Mar 31, 2024

OOPs, sorry I forgot that the same pattern also exists in table.overwrite(). Seems we need another PR to update that to call arrow() once, too.

@kevinjqliu kevinjqliu deleted the kevinjqliu/523-followup branch March 31, 2024 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants