Fix race condition on Table.scan with limit
#545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fokko
approved these changes
Mar 25, 2024
There was a problem hiding this comment.
This is much cleaner as well @kevinjqliu Thanks for fixing this 👍
|
Thanks @kevinjqliu |
HonahX
pushed a commit
to HonahX/iceberg-python
that referenced
this pull request
Mar 28, 2024
(cherry picked from commit 0d12cf4)
HonahX
pushed a commit
that referenced
this pull request
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #542
_task_to_tablereturns row count instead of using shared staterow_counts.When a
limitis set, Future objects running after therow_countslimit is achieved will just be canceled.