-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make optional oauth configurable #486
Make optional oauth configurable #486
Conversation
@Fokko @syun64 @flyrain @RussellSpitzer |
70ddae2
to
414e91d
Compare
Requesting for review one this one please. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall. Left a minor suggestion.
@himadripal Can you fix the issue here? And update the doc in the same PR? Apart from that, this looks good. Thanks for working on this 👍 |
414e91d
to
a4492f1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, left a minor suggestion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @himadripal for working on this, and thanks @flyrain for the review!
#479
In this PR, I have tried to provision to pass all additional optional parameter, along with audience.