Arrow: Support int8 and int16 types
#391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fokko
changed the title
int8 and int16 types
I've checked with Spark, and here byte and short types are converted to integers. I think it makes sense to do this for Arrow as well.
sungwy
approved these changes
Feb 7, 2024
|
Does this imply when we convert an Iceberg table to an arrow schema there will be a loss in the int8 and int 16 types? |
|
@geruh The types will be widened. But when you write the data, the wider type will be used (resulting in more memory/disk usage). |
HonahX
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've checked with Spark, and here byte and short types are converted to integers. I think it makes sense to do this for Arrow as well.
Closes #378