Get Started: Add sqlcatalog and local fs warehouse #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fokko
approved these changes
Feb 4, 2024
There was a problem hiding this comment.
Love it, thanks for extending the docs here @kevinjqliu. I left two small comments.
Co-authored-by: Fokko Driesprong <[email protected]>
kevinjqliu
force-pushed
the
kevinjqliu/add-local-fs-example-to-get-started
branch
from
9c49615 to
06b3a48
Compare
|
thanks for the review @Fokko, I've made changes based on the suggestions |
Fokko
approved these changes
Feb 4, 2024
There was a problem hiding this comment.
Thanks @kevinjqliu I think this is a great addition and makes it easier to get people started with Iceberg 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #326 [Add example of using PyIceberg with minimal external dependencies]