Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: Add support for Python 3.12 #35

Closed
wants to merge 8 commits into from

Conversation

steinsgateted
Copy link

@Fokko
Copy link
Contributor

Fokko commented Oct 2, 2023

Thanks for opening this PR. 3.12 has been released today: https://www.python.org/downloads/release/python-3120/

@Fokko
Copy link
Contributor

Fokko commented Oct 13, 2023

@steinsgateted can you pull in the main branch? It looks like that 3.12 is available: https://github.com/actions/python-versions/releases

@Fokko Fokko added this to the PyIceberg 0.6.0 release milestone Oct 13, 2023
@steinsgateted
Copy link
Author

@Fokko Thank you.
Encountered this problem:

Note: This error originates from the build backend, and is likely not a problem with poetry but with aiohttp (3.8.5) not supporting PEP 517 builds. You can verify this by running 'pip wheel --use-pep517 "aiohttp (==3.8.5)"'.

@jayceslesar
Copy link
Contributor

@steinsgateted looks like there are no 3.12 wheels yet see the discussion on aio-libs/aiohttp#7639

@steinsgateted
Copy link
Author

@jayceslesar Thank you for the information

@Fokko Fokko mentioned this pull request Nov 22, 2023
@Fokko
Copy link
Contributor

Fokko commented Nov 22, 2023

Thanks for picking this up again, it looks like it is now blocked on Poetry: #158

@steinsgateted
Copy link
Author

steinsgateted commented Nov 22, 2023

@Fokko @jayceslesar Thank you

@steinsgateted looks like there are no 3.12 wheels yet see the discussion on aio-libs/aiohttp#7639

I found that 3.9.0b0 supports python3.12.
Do we change 3.8.6 to 3.9?

@MehulBatra
Copy link
Contributor

Looking into this

@Fokko
Copy link
Contributor

Fokko commented Mar 13, 2024

@steinsgateted can you rebase the PR?

@kevinjqliu
Copy link
Contributor

Closing this in favor of #1068

@kevinjqliu kevinjqliu closed this Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants