support pyarrow AzureFileSystem parameters (client_id, client_secret, tenant_id)
#2301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for additional Azure authentication parameters in PyArrow's AzureFileSystem integration. It extends the existing Azure file system initialization to include client ID, client secret, and tenant ID parameters for service principal authentication.
- Adds three new Azure configuration constants for client credentials authentication
- Updates Azure file system initialization to pass client authentication parameters to PyArrow
- Includes reference documentation link for the PyArrow AzureFileSystem API
This reverts commit 7c89a9b.
Fokko
approved these changes
Aug 10, 2025
Comment on lines
+542
to
+547
| if client_id := self.properties.get(ADLS_CLIENT_ID): | ||
| client_kwargs["client_id"] = client_id | ||
| if client_secret := self.properties.get(ADLS_CLIENT_SECRET): | ||
| client_kwargs["client_secret"] = client_secret | ||
| if tenant_id := self.properties.get(ADLS_TENANT_ID): | ||
| client_kwargs["tenant_id"] = tenant_id |
There was a problem hiding this comment.
The client_id, client_secret and tenant_id should be provided together, should we raise a ValueError? This way we hide Arrow exceptions where possible.
There was a problem hiding this comment.
makes sense, added!
|
Nice one @kevinjqliu thanks for adding this 👍 |
gabeiglio
pushed a commit
to Netflix/iceberg-python
that referenced
this pull request
Aug 13, 2025
<!--
Thanks for opening a pull request!
-->
<!-- In the case this PR will resolve an issue, please replace
${GITHUB_ISSUE_ID} below with the actual Github issue id. -->
<!-- Closes #${GITHUB_ISSUE_ID} -->
# Rationale for this change
Similar to apache#2299
This PR adds the rest of the parameters to
[`pyarrow.fs.AzureFileSystem`](https://arrow.apache.org/docs/python/generated/pyarrow.fs.AzureFileSystem.html)
Note the [Azure Data Lake configuration
page](https://github.com/apache/iceberg-python/blob/main/mkdocs/docs/configuration.md#azure-data-lake)
already has these 3 parameters
# Are these changes tested?
# Are there any user-facing changes?
<!-- In the case of user-facing changes, please add the changelog label.
-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Similar to #2299
This PR adds the rest of the parameters to
pyarrow.fs.AzureFileSystemNote the Azure Data Lake configuration page already has these 3 parameters
Are these changes tested?
Are there any user-facing changes?