Skip to content

dep: pin transitive dep google-cloud-storage >=2.0.0 #2161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kevinjqliu
Copy link
Contributor

Rationale for this change

Older versions of google libraries throw

E   UserWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html. The pkg_resources package is slated for removal as early as 2025-11-30. Refrain from using this package or pin to Setuptools<81.

We found a temporary workaround by manually upgrading the libraries in #2127
However, other libraries might depend on these packages and will revert them back to the <2.0 versions. For example, #2145

This PR pins the top-level google-cloud-storage to >=2.0.0 to mitigate this issue.
The side effect is #2145 wont be necessary anymore since [email protected] wont satisfy the dependency constraints

Are these changes tested?

Are there any user-facing changes?

@Fokko
Copy link
Contributor

Fokko commented Jun 30, 2025

I'm confused by both the #2145 dependabot PR, but also this one 🤣

PyIceberg directly depends on cachetools:

cachetools = ">=5.5,<7.0"

But cachetools does not have any dependencies, so also not on google-cloud-storage. Why does it lower the GCP dependencies: https://github.com/apache/iceberg-python/pull/2145/files#diff-f53a023eedfa3fbf2925ec7dc76eecdc954ea94b7e47065393dbad519613dc89L1706-L1717 ?

Adding this constraint would put an unnecessary constraint on the users. We fail on errors, to make sure that we fix deprecations in time, but I don't think this is the right fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants