refactor: consolidate snapshot expiration into MaintenanceTable #2143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move ExpireSnapshots functionality from standalone class to MaintenanceTable - Replace fluent API (table.expire_snapshots().method().commit()) with direct execution (table.maintenance.method()) - Remove ExpireSnapshots class and integrate logic into maintenance operations - Update all tests to use new unified maintenance API - Maintain all existing validation and protection logic for snapshots This change consolidates table maintenance operations under a single interface and simplifies the API by removing the need for explicit commit calls. Breaking change: table.expire_snapshots() API is replaced with table.maintenance.expire_*() methods
|
@Fokko @jayceslesar let me know if you guys prefer i stack this pr into the #1200 or if you both would rather i wait until the #1200 is merged into |
|
Great seeing this PR @ForeverAngry, thanks again for working on this! I'm okay with first merging #1200, but we could also merge this first, and adapt the remove orphan files routine to use |
- Move ExpireSnapshots functionality from standalone class to MaintenanceTable - Replace fluent API (table.expire_snapshots().method().commit()) with direct execution (table.maintenance.method()) - Remove ExpireSnapshots class and integrate logic into maintenance operations - Update all tests to use new unified maintenance API - Maintain all existing validation and protection logic for snapshots This change consolidates table maintenance operations under a single interface and simplifies the API by removing the need for explicit commit calls. Breaking change: table.expire_snapshots() API is replaced with table.maintenance.expire_*() methods
|
@Fokko did you decide if you wanted me to stay stacked on the delete orphans pr, or go ahead and prepare the pr for this, to the main branch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Consolidates snapshot expiration functionality from the standalone
ExpireSnapshotsclass into theMaintenanceTableclass for a unified maintenance API. This was planned work left over from #1880.Are these changes tested?
Yes - but the pr is predicated on the final changes from #1200.
Are there any user-facing changes?
Breaking Changes
ExpireSnapshotsfunctionality toMaintenanceTableExpireSnapshotsclass entirelytable.maintenance.*APIAPI Changes
Before: