Add Avro compression #1976
Open
Add Avro compression #1976
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PyIceberg did not compress the Avro. This will make gzip/deflate the same as in Java.
ndrluis
reviewed
May 7, 2025
|
|
||
| from pyiceberg.avro.codecs.bzip2 import BZip2Codec | ||
| from pyiceberg.avro.codecs.codec import Codec | ||
| from pyiceberg.avro.codecs.deflate import DeflateCodec | ||
| from pyiceberg.avro.codecs.snappy_codec import SnappyCodec | ||
| from pyiceberg.avro.codecs.zstandard_codec import ZStandardCodec | ||
|
|
||
| KNOWN_CODECS: Dict[str, Optional[Type[Codec]]] = { | ||
| AvroCompressionCodec: TypeAlias = Literal["null", "bzip2", "snappy", "zstandard", "deflate"] |
There was a problem hiding this comment.
In other places in the project we use zstd instead of zstandard. What do you think about using zstd?
There was a problem hiding this comment.
Hey @ndrluis that's a great catch! We should use zstd instead. Avro uses zstandard, that's why I copied it here, but it is actually wrong.
There was a problem hiding this comment.
keep in min that this TypeAlias is called AvroCompressionCodec, so it should actually use zstandard instead of zstd, but I've fixed it for Iceberg. LMKWYT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
PyIceberg did not compress the Avro. This will make gzip/deflate the same as in Java.
Are these changes tested?
Existing round-trip tests with FastAvro and Spark. Some tests are extended to both write compressed and uncompressed data.
Are there any user-facing changes?
Smaller and faster manifest files :)