Test transform function consistency for all transforms #1573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fokko
reviewed
Jan 27, 2025
| assert t.transform(source_type)(value) == t.pyarrow_transform(source_type)(pa.array([value])).to_pylist()[0] | ||
| except ValueError as e: | ||
| # Skipping unsupported feature | ||
| if "FeatureUnsupported => Unsupported data type for truncate transform" in str(e): |
There was a problem hiding this comment.
This feels contradictive, since it passes t.can_transform
There was a problem hiding this comment.
yea good point, let me dig into this a little more, i think the main error comes from rust
There was a problem hiding this comment.
Looks like binary is not supported: apache/iceberg-rust#920
Fokko
approved these changes
Jan 30, 2025
There was a problem hiding this comment.
Let's move this in first, and remove the try-catch later on 👍 Thanks @kevinjqliu
|
Thanks! I opened #1591 to track this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I like this test from #1562, lets expand it to include all transforms