Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor bucket transform types #1562

Merged
merged 3 commits into from
Jan 22, 2025
Merged

Refactor bucket transform types #1562

merged 3 commits into from
Jan 22, 2025

Conversation

Fokko
Copy link
Contributor

@Fokko Fokko commented Jan 22, 2025

I think this aligns closer to the spec, and is also more friendly to the end-user:

image

kevinjqliu
kevinjqliu approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@kevinjqliu kevinjqliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This is for BucketTransform not truncate :P

@kevinjqliu kevinjqliu changed the title Refactor truncate transform types Refactor bucket transform types Jan 22, 2025
@Fokko
Copy link
Contributor Author

Fokko commented Jan 22, 2025

@kevinjqliu Thanks, and yes, thanks for correcting the title :p

@Fokko Fokko merged commit 666a926 into apache:main Jan 22, 2025
7 checks passed
@Fokko Fokko deleted the fd-refactor-bucket branch January 22, 2025 21:51
@Fokko Fokko mentioned this pull request Jan 22, 2025
Merged
Fokko added a commit that referenced this pull request Jan 23, 2025
@Fokko
Refactor {year,month,day,hour} transform (#1563)
a0cc563 
Similar to #1562
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinjqliu kevinjqliu kevinjqliu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Fokko @kevinjqliu