Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci] fix make lint #1507

Closed
wants to merge 1 commit into from
Closed

[ci] fix make lint #1507

wants to merge 1 commit into from

Conversation

kevinjqliu
Copy link
Contributor

@kevinjqliu kevinjqliu commented Jan 10, 2025 •
edited
Loading

Ran make lint locally

I think this is due to the last commit. Not sure why it wasn't cause by CI at PR time

@kevinjqliu kevinjqliu requested a review from Fokko January 10, 2025 18:54
@kevinjqliu kevinjqliu mentioned this pull request Jan 10, 2025
Merged
@smaheshwar-pltr smaheshwar-pltr mentioned this pull request Jan 10, 2025
Merged
@kevinjqliu
Copy link
Contributor Author

Addressed in #1499, closing

@kevinjqliu kevinjqliu closed this Jan 10, 2025
@kevinjqliu kevinjqliu deleted the kevinjqliu/fix-lint branch January 10, 2025 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fokko Fokko Awaiting requested review from Fokko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kevinjqliu