Implement column projection #1443
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 19, 2024 00:19
kevinjqliu
reviewed
Dec 19, 2024
Fokko
reviewed
Dec 20, 2024
Fokko
reviewed
Dec 20, 2024
…tion logic to helper method, changed test to use high-level table scan
Fokko
reviewed
Dec 29, 2024
Fokko
reviewed
Dec 29, 2024
Fokko
reviewed
Dec 29, 2024
Fokko
reviewed
Dec 29, 2024
kevinjqliu
reviewed
Jan 3, 2025
kevinjqliu
reviewed
Jan 7, 2025
Fokko
reviewed
Jan 13, 2025
kevinjqliu
reviewed
Jan 20, 2025
Comment on lines
+1279
to
+1287
| project_schema_diff = projected_field_ids.difference(file_project_schema.field_ids) | ||
| should_project_columns = len(project_schema_diff) > 0 | ||
|
|
||
| projected_missing_fields = {} | ||
|
|
||
| if should_project_columns and partition_spec is not None: | ||
| projected_missing_fields = _get_column_projection_values( | ||
| task.file, projected_schema, project_schema_diff, partition_spec | ||
| ) |
There was a problem hiding this comment.
Nit: wdyt about structuring the code like this?
Suggested change
| project_schema_diff = projected_field_ids.difference(file_project_schema.field_ids) | |
| should_project_columns = len(project_schema_diff) > 0 | |
| projected_missing_fields = {} | |
| if should_project_columns and partition_spec is not None: | |
| projected_missing_fields = _get_column_projection_values( | |
| task.file, projected_schema, project_schema_diff, partition_spec | |
| ) | |
| should_project_columns, projected_missing_fields = _get_column_projection_values( | |
| task.file, projected_schema, partition_spec | |
| ) |
and in _get_column_projection_values, move the rest of the logic
def _get_column_projection_values(...):
project_schema_diff = projected_field_ids.difference(file_project_schema.field_ids)
should_project_columns = len(project_schema_diff) > 0
projected_missing_fields = {}
if not should_project_columns:
return False, {}
...
Comment on lines
+1196
to
+1199
| partition_spec = PartitionSpec( | ||
| PartitionField(2, 1000, VoidTransform(), "void_partition_id"), | ||
| PartitionField(2, 1001, IdentityTransform(), "partition_id"), | ||
| ) |
There was a problem hiding this comment.
i think we'd want to test multiple IdentityTransforms here.
im thinking about a case for multiple-level of partitioning in hive-style.
s3://my_table/a=100/b=foo/...parquet
i think _get_column_projection_values might not support this right now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for issue #1401. In which table scans needed to infer partition column by following the column projection rules
Fixes #1401