-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementing namespace_exists function on the REST Catalog #1434
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
0d01759
- Added the namespace_exists function in the RESTCatalog
AhmedNader42 d1e643c
- Removed docstring to match other namespace functions
AhmedNader42 ceffe08
- Added integration test for REST Catalog namespace_exists functionality
AhmedNader42 fcd1111
- Added ASF license to test_rest_catalog.py to recover from failing test
AhmedNader42 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,63 @@ | ||
# Licensed to the Apache Software Foundation (ASF) under one | ||
# or more contributor license agreements. See the NOTICE file | ||
# distributed with this work for additional information | ||
# regarding copyright ownership. The ASF licenses this file | ||
# to you under the Apache License, Version 2.0 (the | ||
# "License"); you may not use this file except in compliance | ||
# with the License. You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, | ||
# software distributed under the License is distributed on an | ||
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
# KIND, either express or implied. See the License for the | ||
# specific language governing permissions and limitations | ||
# under the License. | ||
# pylint:disable=redefined-outer-name | ||
|
||
import pytest | ||
|
||
from pyiceberg.catalog.rest import RestCatalog | ||
|
||
TEST_NAMESPACE_IDENTIFIER = "TEST NS" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hmm, I didn't know that spaces are allowed :D |
||
|
||
|
||
@pytest.mark.integration | ||
@pytest.mark.parametrize("catalog", [pytest.lazy_fixture("session_catalog")]) | ||
def test_namespace_exists(catalog: RestCatalog) -> None: | ||
if not catalog.namespace_exists(TEST_NAMESPACE_IDENTIFIER): | ||
catalog.create_namespace(TEST_NAMESPACE_IDENTIFIER) | ||
|
||
assert catalog.namespace_exists(TEST_NAMESPACE_IDENTIFIER) | ||
|
||
|
||
@pytest.mark.integration | ||
@pytest.mark.parametrize("catalog", [pytest.lazy_fixture("session_catalog")]) | ||
def test_namespace_not_exists(catalog: RestCatalog) -> None: | ||
if catalog.namespace_exists(TEST_NAMESPACE_IDENTIFIER): | ||
catalog.drop_namespace(TEST_NAMESPACE_IDENTIFIER) | ||
|
||
assert not catalog.namespace_exists(TEST_NAMESPACE_IDENTIFIER) | ||
|
||
|
||
@pytest.mark.integration | ||
@pytest.mark.parametrize("catalog", [pytest.lazy_fixture("session_catalog")]) | ||
def test_create_namespace_if_not_exists(catalog: RestCatalog) -> None: | ||
if catalog.namespace_exists(TEST_NAMESPACE_IDENTIFIER): | ||
catalog.drop_namespace(TEST_NAMESPACE_IDENTIFIER) | ||
|
||
catalog.create_namespace_if_not_exists(TEST_NAMESPACE_IDENTIFIER) | ||
|
||
assert catalog.namespace_exists(TEST_NAMESPACE_IDENTIFIER) | ||
|
||
|
||
@pytest.mark.integration | ||
@pytest.mark.parametrize("catalog", [pytest.lazy_fixture("session_catalog")]) | ||
def test_create_namespace_if_already_existing(catalog: RestCatalog) -> None: | ||
if not catalog.namespace_exists(TEST_NAMESPACE_IDENTIFIER): | ||
catalog.create_namespace(TEST_NAMESPACE_IDENTIFIER) | ||
|
||
catalog.create_namespace_if_not_exists(TEST_NAMESPACE_IDENTIFIER) | ||
|
||
assert catalog.namespace_exists(TEST_NAMESPACE_IDENTIFIER) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: the tests here are only verifying against the mock response.
it would be great to test against the actual REST catalog in integration tests.
i noticed that does not exist right now, perhaps we can start a
tests/integration/test_rest_catalog.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, Good point! I was looking for how to properly test this but didn't find any tests touching the REST Catalog. I thought it was a bit out of scope for the initial issue to add a new integration test flow.
Maybe we should open a new enhancement and add the details to it to implement a new integration test for REST Catalog at tests/integration/test_rest_catalog.py like you mentioned. Thoughts? I'm willing to pick it up