Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate the use of last-column-id #1367

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Conversation

Fokko
Copy link
Contributor

@Fokko Fokko commented Nov 25, 2024

This should not be part of the public API: apache/iceberg#11514

This PR depends on a later version of the REST catalog for the integration tests.

This should not be part of the public API:

apache/iceberg#11514

This PR depends on a later version of the REST
catalog for the integration tests.
@Fokko Fokko marked this pull request as ready for review November 25, 2024 10:41
@kevinjqliu
Copy link
Contributor

while looking for references to last-column-id/last_column_id, I found this

return TableMetadataV1.model_construct(last_column_id=-1, schema=Schema())

Meta question. As part of deprecation, should we also remove all internal code references? That way the library itself won't generate additional warnings

@Fokko
Copy link
Contributor Author

Fokko commented Nov 25, 2024

That's the last-column-id on the TableMetadata and not the AddSchemaUpdate :)

@Fokko Fokko merged commit 3b559c4 into apache:main Nov 26, 2024
8 checks passed
@Fokko Fokko deleted the fd-patch-last-column-id branch November 26, 2024 14:17
This was referenced Nov 27, 2024
sungwy pushed a commit to sungwy/iceberg-python that referenced this pull request Dec 7, 2024
This should not be part of the public API:

apache/iceberg#11514

This PR depends on a later version of the REST
catalog for the integration tests.
sungwy pushed a commit to sungwy/iceberg-python that referenced this pull request Dec 7, 2024
This should not be part of the public API:

apache/iceberg#11514

This PR depends on a later version of the REST
catalog for the integration tests.
JE-Chen pushed a commit to JE-Chen/iceberg-python that referenced this pull request Dec 23, 2024
This should not be part of the public API:

apache/iceberg#11514

This PR depends on a later version of the REST
catalog for the integration tests.
sungwy pushed a commit to sungwy/iceberg-python that referenced this pull request Dec 24, 2024
This should not be part of the public API:

apache/iceberg#11514

This PR depends on a later version of the REST
catalog for the integration tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants