Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use dist/release KEYS #1315

Merged
merged 2 commits into from
Nov 12, 2024
Merged

use dist/release KEYS #1315

merged 2 commits into from
Nov 12, 2024

Conversation

kevinjqliu
Copy link
Contributor

@kevinjqliu kevinjqliu commented Nov 12, 2024 •
edited
Loading

Xuanwo
Xuanwo approved these changes Nov 12, 2024
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @kevinjqliu for working on this. LGTM!

@kevinjqliu kevinjqliu marked this pull request as ready for review November 12, 2024 16:01
@kevinjqliu kevinjqliu requested a review from Fokko November 12, 2024 16:01
@kevinjqliu kevinjqliu changed the title use KEYS file from https://downloads.apache.org/iceberg use dist/release KEYS and https://downloads.apache.org/iceberg Nov 12, 2024
@kevinjqliu kevinjqliu changed the title use dist/release KEYS and https://downloads.apache.org/iceberg use dist/release KEYS Nov 12, 2024
Fokko
Fokko approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kevinjqliu for fixing this right away, and thanks @RussellSpitzer and @Xuanwo for reviewing 🚀

@Fokko Fokko merged commit 369b244 into apache:main Nov 12, 2024
7 checks passed
@kevinjqliu kevinjqliu deleted the kevinjqliu/change-keys branch November 12, 2024 19:38
sungwy pushed a commit to sungwy/iceberg-python that referenced this pull request Dec 7, 2024
@kevinjqliu @sungwy
Relase: Use dist/release KEYS (apache#1315)
00154f2 
* use https://downloads.apache.org/iceberg

* use the right url for svn
sungwy pushed a commit to sungwy/iceberg-python that referenced this pull request Dec 7, 2024
@kevinjqliu @sungwy
Relase: Use dist/release KEYS (apache#1315)
0e83fac 
* use https://downloads.apache.org/iceberg

* use the right url for svn
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

@Fokko Fokko Fokko approved these changes

@RussellSpitzer RussellSpitzer RussellSpitzer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update KEYS file reference
4 participants
@kevinjqliu @RussellSpitzer @Fokko @Xuanwo