Add support for boolean expressions and quoted columns #1286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No problem, appreciate the team's work. And thank you for the quick turnaround. |
|
@Fokko Not to rush, but was wondering was the timeline typically is for a fix like this to get merged in and released? Thank you :) |
kevinjqliu
reviewed
Nov 6, 2024
|
we're in the process of releasing 0.8. We could include this PR |
Would appreciate that, thank you! I just removed that comment I missed. |
kevinjqliu
approved these changes
Nov 6, 2024
sungwy
pushed a commit
to sungwy/iceberg-python
that referenced
this pull request
Dec 7, 2024
* Add support for boolean expressions and quoted columns * Add AlwaysTrue & AlwaysFalse support plus tests * Add test for quoted column * Remove commented code --------- Co-authored-by: Mohammad Sheikh <[email protected]>
sungwy
pushed a commit
to sungwy/iceberg-python
that referenced
this pull request
Dec 7, 2024
* Add support for boolean expressions and quoted columns * Add AlwaysTrue & AlwaysFalse support plus tests * Add test for quoted column * Remove commented code --------- Co-authored-by: Mohammad Sheikh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
row_filterexpressions involving abooleanexpression fail. This pull adds in the already-defined boolean literals as part of the list of parsed literals.In addition, identifiers can now be defined with double quotes (
") as part of the SQL spec.