Drop support for Python 3.8 #1221
Conversation
|
The integration job uses Ubuntu 20.04 which will be EOL on April 2025. Ubuntu 20.04 uses Python 3.8 as default, let me know if you'd prefer to use Ubuntu 22.04 on that job instead of installing Python 3.9 as I've done on the PR. |
|
Hi @raulcd thank you very much for putting together this PR. I'm +1 for using ubuntu-22.04 for the integration test to align with what arrow is doing. This will also align the machine with the python CI github workflow, which is actually already running on ubuntu-22.04. |
|
Thanks @sungwy, I've update the job to Ubuntu 22.04. CI is successful. |
| @@ -202,7 +202,7 @@ Deprecated in 0.1.0, will be removed in 0.2.0. The old_property is deprecated. P | |||
|
|
|||
| For the type annotation the types from the `Typing` package are used. | |||
|
|
|||
| PyIceberg offers support from Python 3.8 onwards, we can't use the [type hints from the standard collections](https://peps.python.org/pep-0585/). | |||
| PyIceberg offers support from Python 3.9 onwards, we can't use the [type hints from the standard collections](https://peps.python.org/pep-0585/). | |||
There was a problem hiding this comment.
nit: add a paragraph about dropping 3.8 support at version 0.x (whatever we release this commit as)
There was a problem hiding this comment.
Hi @kevinjqliu, I am unsure I understand where you want me to add this paragraph. Are you suggesting to add it to the mkdocs/docs/contributing.md file? I thought the changelog would be generated from the issues/commits is there any other place where the changelogs / guidelines should be added for that?
There was a problem hiding this comment.
ah sorry about the confusion, i didnt see this is the contributing doc. in that case, this isn't needed.
i thought this was the docs on how to use pyiceberg, in which case we should mention that 3.8 support is dropped in this next release
There was a problem hiding this comment.
LGTM!
Sidenote, I dont see a good place to add a note about dropping python 3.8 support on the docs https://py.iceberg.apache.org/
We can just include this as part of the release notes
|
Merging, since it was already voted to drop python 3.8 in the pyiceberg 0.8.0 release (next release) |
|
Thank you @raulcd for the contribution! |
Thanks @kevinjqliu @sungwy @HonahX for approving the PR! I plan to keep contributing :) |
* Drop support for Python 3.8 * Run poetry lock --no-update * Add usage of Python 3.9 on Ubuntu 20.04 * Update Ubuntu to 22.04 on Integration tests * Add Python 3.10 to python-release workflow
* Drop support for Python 3.8 * Run poetry lock --no-update * Add usage of Python 3.9 on Ubuntu 20.04 * Update Ubuntu to 22.04 on Integration tests * Add Python 3.10 to python-release workflow
This PR drops support for Python 3.8 as successfully voted on the Mailing List here: https://lists.apache.org/thread/50jjtdyfovwqbw8mp5m6rfgmmbxv7qcr
Closes #1121