Skip to content

Suggestions for #1033 #1218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 18 commits into from
Closed

Suggestions for #1033 #1218

wants to merge 18 commits into from

Conversation

edgarrmondragon
Copy link
Contributor

  • s3_signer_endpoint
  • prune any trailing whitespaces
  • fallback to default value instead of "endpoint" property
  • fix test_s3v4_rest_signer_endpoint
  • Fix missing backtick
  • create access_delegation property
  • rename S3_SIGNER_ENDPOINT_DEFAULT_VALUE to S3_SIGNER_ENDPOINT_DEFAULT
  • fix s3.signer.endpoint docs
  • fk typo in signer
  • fix fmt
  • rename ACCESS_DELEGATION_DEFAULT_VALUE to ACCESS_DELEGATION_DEFAULT
  • rename access_delegation to access-delegation
  • fix grammar
  • Suggestions for Access delegation #1033

guilhermecastro and others added 18 commits August 8, 2024 21:40
s3_signer_endpoint
b929c2e
@guitcastro @Fokko
prune any trailing whitespaces
e1d9f64 
Co-authored-by: Fokko Driesprong <[email protected]>
@guitcastro @Fokko
fallback to default value instead of "endpoint" property
f3cfd37 
Co-authored-by: Fokko Driesprong <[email protected]>
fix test_s3v4_rest_signer_endpoint
989bd14
@guitcastro @Fokko
Fix missing backtick
2045f83 
Co-authored-by: Fokko Driesprong <[email protected]>
create access_delegation property
cf54856
rename S3_SIGNER_ENDPOINT_DEFAULT_VALUE to S3_SIGNER_ENDPOINT_DEFAULT
a197d28
fix s3.signer.endpoint docs
a425b69
fk typo in signer
10cc361
fix fmt
07325e5
merge with s3_signer_endpoint
f4fc2ec
Merge remote-tracking branch 'origin' into access_delegation
35c7cd3
rename ACCESS_DELEGATION_DEFAULT_VALUE to ACCESS_DELEGATION_DEFAULT
da3490b
rename access_delegation to access-delegation
238df70
Merge remote-tracking branch 'origin' into access_delegation
cf0dc4a
@guitcastro @sungwy
fix grammar
ae4a677 
Co-authored-by: Sung Yun <[email protected]>
@guitcastro
Merge branch 'main' into access_delegation
da322e6
@edgarrmondragon
Suggestions for #1033
0c4feec
@edgarrmondragon edgarrmondragon deleted the 1033-suggestions branch October 5, 2024 06:24
@edgarrmondragon edgarrmondragon restored the 1033-suggestions branch October 5, 2024 06:25
@edgarrmondragon edgarrmondragon deleted the 1033-suggestions branch November 4, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edgarrmondragon @guitcastro