Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump duckdb to version 1.1.0 #1149

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Conversation

kevinjqliu
Copy link
Contributor

@kevinjqliu kevinjqliu commented Sep 9, 2024

Duckdb version 1.1.0 added support for automatic retries when installing extensions (duckdb/duckdb#13122).
This will help resolve the intermittent CI issue observed in #787

poetry add [email protected] --optional
# remove pyproject.toml changes
poetry lock --no-update

@kevinjqliu kevinjqliu mentioned this pull request Sep 9, 2024
pyproject.toml Outdated
@@ -64,7 +64,7 @@ zstandard = ">=0.13.0,<1.0.0"
tenacity = ">=8.2.3,<10.0.0"
pyarrow = { version = ">=14.0.0,<18.0.0", optional = true }
pandas = { version = ">=1.0.0,<3.0.0", optional = true }
duckdb = { version = ">=0.5.0,<2.0.0", optional = true }
duckdb = {version = "1.1.0", optional = true}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how I feel about pinning this to a single version 🤔

Is this necessary to resolve the issues with our CI, given that the new version is out, and our upper limit is already <2.0.0?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, not sure about this one. The CI issue can only be resolved by v1.1.0 or higher. I'm not sure if CI will automatically pick the newest version of the library.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's see if its necessary kevinjqliu#4

v1.1.0 is already the official version on pypi
https://pypi.org/project/duckdb/#history

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like that didn't work, its still installing duckdb v1.0.0

@kevinjqliu kevinjqliu force-pushed the kevinjqliu/duckdb-v1.1.0 branch 3 times, most recently from d3225a8 to 7e5dc0c Compare September 9, 2024 22:59
@kevinjqliu kevinjqliu force-pushed the kevinjqliu/duckdb-v1.1.0 branch from 7e5dc0c to de5fbbd Compare September 9, 2024 23:01
@kevinjqliu
Copy link
Contributor Author

Updated the PR to only change duckdb from v1.0.0 to v1.1.0 in the poetry.lock file

@kevinjqliu
Copy link
Contributor Author

@sungwy instead of pinning duckdb to v1.1.0, i just change the underlying poetry.lock to reference version 1.1.0. PTAL

@sungwy
Copy link
Collaborator

sungwy commented Sep 10, 2024

Nice! I think dependabot also opened a PR to do the same. I'll approve and merge this PR, but I think it's good to learn that it'll be taken care of automatically! https://github.com/apache/iceberg-python/pull/1152/files

@sungwy sungwy merged commit 2e9ec04 into apache:main Sep 10, 2024
8 checks passed
@kevinjqliu kevinjqliu deleted the kevinjqliu/duckdb-v1.1.0 branch September 10, 2024 16:17
sungwy pushed a commit to sungwy/iceberg-python that referenced this pull request Dec 7, 2024
sungwy pushed a commit to sungwy/iceberg-python that referenced this pull request Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants