-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump duckdb
to version 1.1.0
#1149
Conversation
pyproject.toml
Outdated
@@ -64,7 +64,7 @@ zstandard = ">=0.13.0,<1.0.0" | |||
tenacity = ">=8.2.3,<10.0.0" | |||
pyarrow = { version = ">=14.0.0,<18.0.0", optional = true } | |||
pandas = { version = ">=1.0.0,<3.0.0", optional = true } | |||
duckdb = { version = ">=0.5.0,<2.0.0", optional = true } | |||
duckdb = {version = "1.1.0", optional = true} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure how I feel about pinning this to a single version 🤔
Is this necessary to resolve the issues with our CI, given that the new version is out, and our upper limit is already <2.0.0?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, not sure about this one. The CI issue can only be resolved by v1.1.0 or higher. I'm not sure if CI will automatically pick the newest version of the library.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's see if its necessary kevinjqliu#4
v1.1.0 is already the official version on pypi
https://pypi.org/project/duckdb/#history
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like that didn't work, its still installing duckdb v1.0.0
d3225a8
to
7e5dc0c
Compare
7e5dc0c
to
de5fbbd
Compare
Updated the PR to only change duckdb from v1.0.0 to v1.1.0 in the poetry.lock file |
@sungwy instead of pinning duckdb to v1.1.0, i just change the underlying |
Nice! I think dependabot also opened a PR to do the same. I'll approve and merge this PR, but I think it's good to learn that it'll be taken care of automatically! https://github.com/apache/iceberg-python/pull/1152/files |
Duckdb version 1.1.0 added support for automatic retries when installing extensions (duckdb/duckdb#13122).
This will help resolve the intermittent CI issue observed in #787