Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase the minimal required pyarrow version to 14.0.0 #1090

Merged
merged 1 commit into from
Aug 24, 2024

Conversation

ndrluis
Copy link
Collaborator

@ndrluis ndrluis commented Aug 22, 2024

We rely on the 'promote_options' argument in the 'concat_tables' method, which is only supported in version 14.0 and above.

Solves #1089

@ndrluis ndrluis requested review from sungwy and Fokko August 22, 2024 14:16
pyproject.toml Outdated
@@ -94,7 +94,7 @@ pytest-mock = "3.14.0"
pyspark = "3.5.2"
cython = "3.0.11"
deptry = ">=0.14,<0.20"
docutils = "!=0.21.post1" # https://github.com/python-poetry/poetry/issues/9248#issuecomment-2026240520
docutils = "!=0.21.post1" # https://github.com/python-poetry/poetry/issues/9248#issuecomment-2026240520
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, what happened here? 🙂

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My auto-formatter is doing more than what I want it to do.

@@ -61,7 +61,7 @@ fsspec = ">=2023.1.0,<2025.1.0"
pyparsing = ">=3.1.0,<4.0.0"
zstandard = ">=0.13.0,<1.0.0"
tenacity = ">=8.2.3,<10.0.0"
pyarrow = { version = ">=9.0.0,<18.0.0", optional = true }
pyarrow = { version = ">=14.0.0,<18.0.0", optional = true }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for raising this issue and correcting the constraints!

We rely on the 'promote_options' argument in the 'concat_tables' method, which is only supported in version 14.0 and above.
@ndrluis ndrluis changed the title Increase the minimum required version of pyarrow. Increase the minimal required pyarrow version to 14.0.0 Aug 22, 2024
@sungwy sungwy merged commit 9503ae2 into apache:main Aug 24, 2024
7 checks passed
@ndrluis ndrluis deleted the pyarrow-version branch August 26, 2024 18:01
sungwy pushed a commit to sungwy/iceberg-python that referenced this pull request Dec 7, 2024
We rely on the 'promote_options' argument in the 'concat_tables' method, which is only supported in version 14.0 and above.
sungwy pushed a commit to sungwy/iceberg-python that referenced this pull request Dec 7, 2024
We rely on the 'promote_options' argument in the 'concat_tables' method, which is only supported in version 14.0 and above.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants