Support s3.signer.endpoint for nessie #1029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndrluis
reviewed
Aug 9, 2024
Fokko
reviewed
Aug 9, 2024
Fokko
reviewed
Aug 9, 2024
Co-authored-by: Fokko Driesprong <[email protected]>
Co-authored-by: Fokko Driesprong <[email protected]>
Fokko
reviewed
Aug 9, 2024
Co-authored-by: Fokko Driesprong <[email protected]>
ndrluis
approved these changes
Aug 9, 2024
This was referenced Aug 9, 2024
Merged
kevinjqliu
reviewed
Aug 9, 2024
kevinjqliu
reviewed
Aug 9, 2024
kevinjqliu
approved these changes
Aug 9, 2024
Fokko
approved these changes
Aug 12, 2024
There was a problem hiding this comment.
@guitcastro Can you run make lint to fix the style issues:
File : error: indent/outdent mismatch: 7.
Warning: Failed formatting content of a yaml code block (line 278 before formatting). Filename: /home/runner/work/iceberg-python/iceberg-python/mkdocs/docs/configuration.md
Warning: Failed formatting content of a python code block (line 32 before formatting). Filename: /home/runner/work/iceberg-python/iceberg-python/mkdocs/docs/how-to-release.md
Warning: Failed formatting content of a python code block (line 1046 before formatting). Filename: /home/runner/work/iceberg-python/iceberg-python/mkdocs/docs/api.md
Warning: Failed formatting content of a python code block (line 1108 before formatting). Filename: /home/runner/work/iceberg-python/iceberg-python/mkdocs/docs/api.md
I think this is good to get in 👍
|
@Fokko Done! |
|
Thanks @guitcastro for picking this up, and thanks @ndrluis and @kevinjqliu for the review 🙌 |
sungwy
pushed a commit
to sungwy/iceberg-python
that referenced
this pull request
Dec 7, 2024
* s3_signer_endpoint * prune any trailing whitespaces Co-authored-by: Fokko Driesprong <[email protected]> * fallback to default value instead of "endpoint" property Co-authored-by: Fokko Driesprong <[email protected]> * fix test_s3v4_rest_signer_endpoint * Fix missing backtick Co-authored-by: Fokko Driesprong <[email protected]> * rename S3_SIGNER_ENDPOINT_DEFAULT_VALUE to S3_SIGNER_ENDPOINT_DEFAULT * fix s3.signer.endpoint docs * fk typo in signer * fix fmt --------- Co-authored-by: guilhermecastro <[email protected]> Co-authored-by: Fokko Driesprong <[email protected]>
sungwy
pushed a commit
to sungwy/iceberg-python
that referenced
this pull request
Dec 7, 2024
* s3_signer_endpoint * prune any trailing whitespaces Co-authored-by: Fokko Driesprong <[email protected]> * fallback to default value instead of "endpoint" property Co-authored-by: Fokko Driesprong <[email protected]> * fix test_s3v4_rest_signer_endpoint * Fix missing backtick Co-authored-by: Fokko Driesprong <[email protected]> * rename S3_SIGNER_ENDPOINT_DEFAULT_VALUE to S3_SIGNER_ENDPOINT_DEFAULT * fix s3.signer.endpoint docs * fk typo in signer * fix fmt --------- Co-authored-by: guilhermecastro <[email protected]> Co-authored-by: Fokko Driesprong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR honor
s3.signer.endpointproperty, fixing the first point in #1028.