Skip to content

Commit

Permalink
sql-catalog: Default create_engine echo to False (#360)
Browse files Browse the repository at this point in the history
* default create_engine echo to False

* Update pyiceberg/catalog/sql.py

Co-authored-by: Fokko Driesprong <[email protected]>

---------

Co-authored-by: Fokko Driesprong <[email protected]>
  • Loading branch information
kevinjqliu and Fokko authored Feb 4, 2024
1 parent fa15877 commit a276112
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion pyiceberg/catalog/sql.py
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,8 @@ def __init__(self, name: str, **properties: str):

if not (uri_prop := self.properties.get("uri")):
raise NoSuchPropertyException("SQL connection URI is required")
self.engine = create_engine(uri_prop, echo=True)
echo = bool(self.properties.get("echo", False))
self.engine = create_engine(uri_prop, echo=echo)

self._ensure_tables_exist()

Expand Down

0 comments on commit a276112

Please sign in to comment.