Skip to content

Commit

Permalink
typealias for table version replaced in all files
Browse files Browse the repository at this point in the history
  • Loading branch information
MehulBatra committed Apr 3, 2024
1 parent bf24eb8 commit 626a387
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 6 deletions.
5 changes: 3 additions & 2 deletions pyiceberg/table/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,7 @@
KeyDefaultDict,
Properties,
Record,
TableVersion,
)
from pyiceberg.types import (
IcebergType,
Expand Down Expand Up @@ -288,7 +289,7 @@ def _apply(self, updates: Tuple[TableUpdate, ...], requirements: Tuple[TableRequ

return self

def upgrade_table_version(self, format_version: Literal[1, 2]) -> Transaction:
def upgrade_table_version(self, format_version: TableVersion) -> Transaction:
"""Set the table to a certain version.
Args:
Expand Down Expand Up @@ -1018,7 +1019,7 @@ def scan(
)

@property
def format_version(self) -> Literal[1, 2]:
def format_version(self) -> TableVersion:
return self.metadata.format_version

def schema(self) -> Schema:
Expand Down
8 changes: 4 additions & 4 deletions tests/utils/test_manifest.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
# under the License.
# pylint: disable=redefined-outer-name,arguments-renamed,fixme
from tempfile import TemporaryDirectory
from typing import Dict, Literal
from typing import Dict

import fastavro
import pytest
Expand All @@ -39,7 +39,7 @@
from pyiceberg.schema import Schema
from pyiceberg.table.snapshots import Operation, Snapshot, Summary
from pyiceberg.transforms import IdentityTransform
from pyiceberg.typedef import Record
from pyiceberg.typedef import Record, TableVersion
from pyiceberg.types import IntegerType, NestedField


Expand Down Expand Up @@ -308,7 +308,7 @@ def test_read_manifest_v2(generated_manifest_file_file_v2: str) -> None:

@pytest.mark.parametrize("format_version", [1, 2])
def test_write_manifest(
generated_manifest_file_file_v1: str, generated_manifest_file_file_v2: str, format_version: Literal[1, 2]
generated_manifest_file_file_v1: str, generated_manifest_file_file_v2: str, format_version: TableVersion
) -> None:
io = load_file_io()
snapshot = Snapshot(
Expand Down Expand Up @@ -478,7 +478,7 @@ def test_write_manifest(

@pytest.mark.parametrize("format_version", [1, 2])
def test_write_manifest_list(
generated_manifest_file_file_v1: str, generated_manifest_file_file_v2: str, format_version: Literal[1, 2]
generated_manifest_file_file_v1: str, generated_manifest_file_file_v2: str, format_version: TableVersion
) -> None:
io = load_file_io()

Expand Down

0 comments on commit 626a387

Please sign in to comment.