properties validator

apache · Mar 9, 2024 · 428b894 · 428b894
1 parent 9fe9cff
commit 428b894
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 4 deletions.
diff --git a/pyiceberg/catalog/rest.py b/pyiceberg/catalog/rest.py
@@ -149,9 +149,12 @@ class CreateTableRequest(IcebergBaseModel):
     partition_spec: Optional[PartitionSpec] = Field(alias="partition-spec")
     write_order: Optional[SortOrder] = Field(alias="write-order")
     stage_create: bool = Field(alias="stage-create", default=False)
-    properties: Properties = Field(default_factory=dict)
+    properties: Dict[str, str] = Field(default_factory=dict)
+
     # validators
-    transform_properties_dict_value_to_str = field_validator('properties', mode='before')(transform_dict_value_to_str)
+    @field_validator('properties', mode='before')
+    def transform_properties_dict_value_to_str(cls, properties: Properties) -> Dict[str, str]:
+        return transform_dict_value_to_str(properties)
 
 
 class RegisterTableRequest(IcebergBaseModel):

diff --git a/pyiceberg/table/__init__.py b/pyiceberg/table/__init__.py
@@ -473,7 +473,7 @@ class SetLocationUpdate(TableUpdate):
 
 class SetPropertiesUpdate(TableUpdate):
     action: TableUpdateAction = TableUpdateAction.set_properties
-    updates: Properties
+    updates: Dict[str, str]
 
     @field_validator('updates', mode='before')
     def transform_properties_dict_value_to_str(cls, properties: Properties) -> Dict[str, str]:

diff --git a/pyiceberg/table/metadata.py b/pyiceberg/table/metadata.py
@@ -221,7 +221,9 @@ class TableMetadataCommonFields(IcebergBaseModel):
     current-snapshot-id even if the refs map is null."""
 
     # validators
-    transform_properties_dict_value_to_str = field_validator('properties', mode='before')(transform_dict_value_to_str)
+    @field_validator('properties', mode='before')
+    def transform_properties_dict_value_to_str(cls, properties: Properties) -> Dict[str, str]:
+        return transform_dict_value_to_str(properties)
 
     def snapshot_by_id(self, snapshot_id: int) -> Optional[Snapshot]:
         """Get the snapshot by snapshot_id."""