Skip to content

Commit

Permalink
Disable justication from test
Browse files Browse the repository at this point in the history
  • Loading branch information
Sreesh Maheshwar committed Dec 23, 2024
1 parent 64e7748 commit 18c7674
Showing 1 changed file with 17 additions and 12 deletions.
29 changes: 17 additions & 12 deletions tests/integration/test_partitioning_key.py
Original file line number Diff line number Diff line change
Expand Up @@ -729,18 +729,23 @@
["special string"],
Record(**{"special#string#field": "special string"}), # type: ignore
"special%23string%23field=special%20string",
f"""CREATE TABLE {identifier} (
`special#string#field` string
)
USING iceberg
PARTITIONED BY (
identity(`special#string#field`)
)
""",
f"""INSERT INTO {identifier}
VALUES
('special string')
""",
# Spark currently writes differently to PyIceberg w.r.t special column name sanitization so justification
# (comparing expected value with Spark behavior) would fail: PyIceberg produces
# Record[special_x23string_x23field='special string'], not Record[special#string#field='special string'].
None,
None,
# f"""CREATE TABLE {identifier} (
# `special#string#field` string
# )
# USING iceberg
# PARTITIONED BY (
# identity(`special#string#field`)
# )
# """,
# f"""INSERT INTO {identifier}
# VALUES
# ('special string')
# """,
),
],
)
Expand Down

0 comments on commit 18c7674

Please sign in to comment.