Skip to content

fix: handle missing parent snapshots in ExpireSnapshots #671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dhananjaykrutika wants to merge 4 commits into
base: main
Choose a base branch
from
+91 −1
Open

fix: handle missing parent snapshots in ExpireSnapshots #671

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7d1099c
fix: handle missing parent snapshots in ExpireSnapshots
Dec 21, 2025
dfb103a
test: add validation for missing parent snapshots in ExpireSnapshots
Jan 12, 2026
e5e3f55
FIx lint error
Jan 13, 2026
c08ea13
Merge remote-tracking branch 'upstream/main' into missing-parent-snap…
Jan 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion table/transaction.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,9 @@ func (t *Transaction) ExpireSnapshots(opts ...ExpireSnapshotsOpt) error {
for {
snap, err := t.meta.SnapshotByID(snapId)
if err != nil {
return err
// Parent snapshot may have been removed by a previous expiration.
// Treat missing parent as end of chain - this is expected behavior.
break
Comment on lines 250 to +253
Copy link
Contributor

@twuebi twuebi Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we match on the specific error type?

Copy link
Contributor Author

@dhananjaykrutika dhananjaykrutika Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@twuebi not sure I understand. There's really only one reason SnapshotByID() fails -- when the given snapshot ID doesn't exist in snapshotList list.

Copy link
Contributor

@twuebi twuebi Jan 9, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably goes beyond the scope of this PR, if the only reason for SnapshotByID to ever error is not found, then it should probably become a bool, ptr or simply just ptr interface.

Relying on the function to only return an err for not found means that we rely on something that's not statically checked, although unlikely, someone may change SnapshotByID to return err on other cases too, and we'd treat that as happy path here.

}

snapAge := time.Now().UnixMilli() - snap.TimestampMs
Expand Down
Loading