feat(metadata): export UpdateTable & fixes #580
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
twuebi
commented
Sep 27, 2025
twuebi
commented
- exports UpdateTable so that outside packages can use it
- adds metadata log maintenance to the builder, i.e. based on currentFileLocation, an entry is added to the metadata log & on Build, we trim the metadata log
- ports remaining tests from iceberg-rust and implements fixes for them
zeroshade
requested changes
Oct 1, 2025
Comment on lines
-207
to
+217
| b.lastUpdatedMS = metadata.LastUpdatedMillis() | ||
| b.lastUpdatedMS = 0 |
Member
There was a problem hiding this comment.
what's the reasoning for this change?
Contributor
Author
There was a problem hiding this comment.
it's java & rust behavior, the if condition in Build() checks if b.lastUpdatedMS == 0 and only then updates it to Now(), according to spec, it should always be updated to Now():
| } | ||
|
|
||
| func NewMetadataBuilder() (*MetadataBuilder, error) { | ||
| func NewMetadataBuilder(formatVersion int) (*MetadataBuilder, error) { |
Member
There was a problem hiding this comment.
we should probably error if an invalid format version is passed (i.e. one we don't support)
Contributor
Author
There was a problem hiding this comment.
oh, missed that, added, thanks!
twuebi
force-pushed
the
tp/update-table-and-fixes
branch
from
93f64ba to
7499241
Compare
zeroshade
approved these changes
Oct 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.