feat: Refresh method support for table #152
Conversation
| friend class Table; | ||
|
|
There was a problem hiding this comment.
| friend class Table; |
test/in_memory_catalog_test.cc
Outdated
| ASSERT_TRUE(table.value()->current_snapshot().has_value()); | ||
| ASSERT_EQ(table.value()->current_snapshot().value()->snapshot_id, 3055729675574597004); | ||
|
|
||
| // Now we don't support commit method in catalog, so here only test refresh with the |
There was a problem hiding this comment.
I think we can add a test/mock_catalog.h to use gmock to write a MockCatalog so that we can inject table metadata at any time by mocking the call of Catalog::LoadTable. In the future, we may need to mock the catalog a lot of times, so I think it deserves to be added.
lishuxu
force-pushed
the
feature/refresh-table
branch
from
8e29a16 to
323aebe
Compare
src/iceberg/table.cc
Outdated
|
|
||
| namespace iceberg { | ||
|
|
||
| const std::string& Table::uuid() const { return metadata_->table_uuid; } | ||
|
|
||
| Status Table::Refresh() { | ||
| if (!catalog_) { | ||
| return InvalidArgument("Refresh is not supported for table without a catalog"); |
There was a problem hiding this comment.
| return InvalidArgument("Refresh is not supported for table without a catalog"); | |
| return NotSupported("Refresh is not supported for table without a catalog"); |
| @@ -93,6 +93,10 @@ class ICEBERG_EXPORT InMemoryCatalog | |||
| std::unique_ptr<iceberg::TableBuilder> BuildTable(const TableIdentifier& identifier, | |||
| const Schema& schema) const override; | |||
|
|
|||
| protected: | |||
| Status UpdateTableMetaLocationInternal(const TableIdentifier& identifier, | |||
There was a problem hiding this comment.
Please remove this function. We need to use GMock to update the location without hacking any API.
|
|
||
| namespace iceberg { | ||
|
|
||
| class ICEBERG_EXPORT MockInMemoryCatalog : public InMemoryCatalog { |
There was a problem hiding this comment.
Please take a look at https://google.github.io/googletest/gmock_for_dummies.html#writing-the-mock-class to use MOCK_METHOD to override functions of Catalog. Then you can use EXPECT_CALL with WillOnce of MockCatalog::LoadTable to mock different returns for each time.
No description provided.