HIVE-28644: Iceberg: Add support for SMART OPTIMIZE feature #5621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
difin
changed the title
asf-ci-hive
added
tests failed
tests pending
tests unstable
and removed
tests pending
tests failed
labels
asf-ci-hive
added
tests pending
tests unstable
and removed
tests unstable
tests pending
labels
asf-ci-hive
added
tests pending
tests failed
and removed
tests failed
tests pending
labels
asf-ci-hive
added
tests pending
tests failed
and removed
tests failed
tests pending
labels
asf-ci-hive
added
tests pending
tests failed
and removed
tests failed
tests pending
labels
asf-ci-hive
added
tests pending
tests failed
and removed
tests failed
tests pending
labels
|
deniskuzZ
reviewed
Apr 14, 2025
| @@ -63,6 +59,15 @@ public Boolean compact(Table table, CompactionInfo ci) throws Exception { | |||
| return false; | |||
| } | |||
|
|
|||
| if (ci.type == CompactionType.SMART_OPTIMIZE) { | |||
| ci.type = compactionEvaluator.determineCompactionType(); | |||
There was a problem hiding this comment.
Can we create a local var CompactionType type = ompactionEvaluator.determineCompactionType() and assign to ci.type after the null check?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Added support for smart optimization as part of 'OPTIMIZE TABLE ... REWRITE DATA' command so that compaction type will be determined at runtime by analyzing the state of the table/partition to be compacted.
Why are the changes needed?
To improve compaction by determining the best compaction type (MAJOR, MINOR) at runtime for 'OPTIMIZE TABLE ... REWRITE DATA' command.
Does this PR introduce any user-facing change?
No
Is the change a dependency upgrade?
No
How was this patch tested?
Updated existing unit tests and q-tests.