Skip to content

Comments

Fix documentation title sequence warnings#15337

Open
sanjana2505006 wants to merge 3 commits intoapache:7.0.xfrom
sanjana2505006:fix/docs-title-sequence
Open

Fix documentation title sequence warnings#15337
sanjana2505006 wants to merge 3 commits intoapache:7.0.xfrom
sanjana2505006:fix/docs-title-sequence

Conversation

@sanjana2505006
Copy link
Contributor

Fixes #14898.
I fixed the "section title out of sequence" warnings by adjusting the header levels in the .adoc files and using leveloffset in index.adoc to keep them consistent.

(Note: I couldn't find eventsAutoTimestamping.adoc in the repo, so I applied the fix to the other files that were throwing the same warning.)

Adjusts heading levels in included AsciiDoc files and uses leveloffset to resolve 'section title out of sequence' warnings.
@sanjana2505006
Copy link
Contributor Author

@jamesfredley Whenever you get a chance, please review and let me know if any changes are needed

Copy link
Contributor

@sbglasius sbglasius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@sanjana2505006
Copy link
Contributor Author

@sbglasius Whenever you get a chance, please review and let me know if any changes are needed

return name().toLowerCase(Locale.ENGLISH);
}

public String getSourcePath(String path, Language language) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes to this file don't appear to be material. We should revert them.

@jdaugherty
Copy link
Contributor

@sanjana2505006 can you please generate the single guide prior to your change & with this change? Then attach the results to this PR to assist in our review?

@bito-code-review
Copy link

The changes to TestFramework.java are purely cosmetic: they adjust line breaks for readability, remove an extra space, and convert a switch expression to a statement. These don't alter functionality, so reverting them is fine if the original style is preferred. No logic changes detected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

Documentation: Cleanup Title Sequence

3 participants